fix: The DATABASE_URL set in .env.test doesn't include a colon between the username and password.#246
Merged
cullylarson merged 1 commit intocanaryfrom Feb 9, 2022
Conversation
…n the username and password.
cullylarson
commented
Feb 9, 2022
| # ENV vars here override .env when running tests | ||
| DATABASE_URL="postgresql://<%= db.dev.user %><%= db.dev.password %>@<%= db.dev.host %>:<%= db.dev.port %>/<%= db.test.name %>?schema=public" | ||
| APP_SECRET=foo No newline at end of file | ||
| DATABASE_URL="postgresql://<%= db.dev.user %><% if (db.dev.password) { %>:<%= db.dev.password %><% } %>@<%= db.dev.host %>:<%= db.dev.port %>/<%= db.test.name %>?schema=public" |
Contributor
Author
There was a problem hiding this comment.
I just copied this from _.env.ejs.
kgajera
approved these changes
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you provide a database password during setup, the
DATABASE_URLset in.env.testwill not have a colon between the username and password. If no password is provided, it works fine.Changes
_.env.test.ejsto put a colon between the username and password if a password is provided.Checklist