ci: add os matrix to run tests on windows#261
Merged
Conversation
code-jenn-or
approved these changes
May 23, 2022
kgajera
force-pushed
the
ci/add-os-matrix-with-windows
branch
17 times, most recently
from
e960913 to
4cacc74
Compare
kgajera
force-pushed
the
ci/add-os-matrix-with-windows
branch
from
4cacc74 to
08ea92f
Compare
kgajera
force-pushed
the
ci/add-os-matrix-with-windows
branch
from
08ea92f to
f7ddd8c
Compare
| - name: Set up test database | ||
| env: | ||
| DATABASE_URL: postgresql://postgres:postgres@localhost/${{ steps.create-app.outputs.appName }}_test | ||
| DATABASE_URL: postgresql://postgres:postgres@localhost/${{ needs.create-app.outputs.appName }}_test |
Contributor
There was a problem hiding this comment.
Love when I learn a new part of the capabilities by reviewing a PR. needs is something I hadn't seen before.
| "typescript": "^4.4.3" | ||
| "ts-node-dev": "^2.0.0-0", | ||
| "tsconfig-paths": "^4.0.0", | ||
| "typescript": "^4.7.2" |
| files.map(async (file) => { | ||
| const toFile = cleanTemplateDestPath(file.replace(from, to)); | ||
| // Normalize the file path for Windows to ensure back-slashes are used | ||
| const filePath = path.normalize(file); |
mthomps4
approved these changes
May 25, 2022
code-jenn-or
approved these changes
May 25, 2022
Contributor
code-jenn-or
left a comment
code-jenn-or
left a comment
There was a problem hiding this comment.
Looks great and all the tests are passing for both OS and node matrices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
https://github.com/echobind/bisonapp/actions/runs/2386787858
ts-node-dev. These would occur in new bison apps even without any changes introduced by this PR.Fixes #127