feat: engine-scoped 404 and 500 error pages#89
Merged
Conversation
rescue_from ActiveRecord::RecordNotFound always renders the engine's 404 view within the dashboard chrome. rescue_from StandardError renders the engine's 500 view in production; re-raises in development so the Rails debug page is preserved. Declaration order ensures the more-specific RecordNotFound handler takes precedence over StandardError. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50
Summary
rescue_from ActiveRecord::RecordNotFoundrenders the engine's 404 view within the dashboard chromerescue_from StandardErrorrenders the engine's 500 view in production; re-raises whenconsider_all_requests_localis true so the Rails debug page is preserved in developmentStandardErroris declared first so the more-specificRecordNotFoundhandler (declared last) takes precedencesqw-page-header,sqw-empty) and include a "Back to Dashboard" linkTest plan
bundle exec rakepasses (329 examples, 0 failures, no Rubocop offenses)GET /solid_stack/jobs/99999returns 404 with dashboard chromeconsider_all_requests_local = falseinspec/dummy/config/environments/development.rb🤖 Generated with Claude Code