feat: sortable columns on jobs, failed jobs, and history (#78)#98
Merged
Conversation
Adds server-side ?sort=&direction= params to three queue list views. Sort state is preserved across filter changes, tab switches, and period buttons. A shared sort_header_th helper generates the <th> with aria-sort and direction indicator from a URL proc. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sort_header_thhelper added toApplicationHelper— generates a<th>witharia-sort, direction indicator (↑/↓), and URL via a lambda; reused across all three views?sort=class_name|queue_name|priority|created_at) — SQL ORDER via the joinedsolid_queue_jobstable; sort+direction threaded through tabs, period buttons, filter form, discard redirect, and bulk selection form?sort=class_name|queue_name|created_at) — same pattern;references(:job)always applied for the LEFT OUTER JOIN?sort=class_name|queue_name|finished_at) — direct columns onsolid_queue_jobs, no join requiredTest plan
bundle exec rakepassesCloses #78
🤖 Generated with Claude Code