Removed find_package command for caches#7
Merged
akoerner1 merged 1 commit intoeclipse-adore:mainfrom Mar 26, 2026
Merged
Conversation
- This workaround became obsolete by commit eclipse-adore/adore_map@8d0b31a by @akoerner1 (thx!) Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
15 tasks
akoerner1
pushed a commit
to eclipse-adore/adore
that referenced
this pull request
Mar 26, 2026
## Description Please provide a brief summary of the changes you made and why they are necessary. This PR is related to the feature to download maps directly from WFS. The PR removes dependencies on library caches from adore_test_programs/adore_map_downloader_test/CMakeLists.txt. This is related to thirteen (13) currently active micro-PRs with a similar motivation: They all remove on line in CMakeLists, a find_package command for caches (for a list, see below Section "Related Issues"). This line had been inserted as a workaround for a building issue. This has recently become obsolete by commit eclipse-adore/adore_map@8d0b31a by @akoerner1 (thanks a lot!) ## Type of Change Please delete options that are not relevant: - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (adds or updates documentation) - [ ] Refactor (non-breaking change for code readability/structure) - [x] Other (please describe): Cleaning up (removal of an obsolete workaround) ## Checklist - [x] I have performed a self-review of my own code. - [x] I have signed and submitted the Eclipse Foundation Contributors Agreement: https://www.eclipse.org/legal/eca/. - [x] My last commit was made with the `--signoff` flag as required by the Eclipse Foundation. - [x] I have commented my code, particularly in hard-to-understand areas and provided a README.md when necessary. - [ ] I have added tests that prove my fix is effective or that my feature works. - [x] Tests pass locally with my changes: (run 'make test' on the ADORe project root to run unit tests). - [ ] I have updated the documentation in `documentation/technical_reference_manual` where necessary. - [ ] I have updated the `THIRD-PARTY.md` if I have introduced new third-party libraries or dependencies to the project. - [ ] I have updated the `CONTRIBUTERS.md` if I wish to acknowledged for my contribution. ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so others can reproduce. - adore/adore_test_programs/adore_map_downloader_test/basic_map_loading_from_wfs_test.cpp: after building and providing the password for adore-ts_reader in adore/adore_test_programs/adore_map_downloader_test/config/r2s_wfs_config_bs.json, start the development environment a second time and go to .colcon_workspace/install/adore_map_downloader_test/bin and call ./basic_map_loading_from_wfs_test w/o parameters. I.a., you should see a line "All tests passed successfully, good!". - unit tests (in particular the ones related to MapDownloadCacheTest.* and MapTest.*): they should pass - 'just ci' (outside the development environment): should finish without failing **Test Configuration**: - OS: Ubuntu Linux (Noble Numbat) - Docker Version: 28.4.0 ## Screenshots (if applicable) Include any relevant screenshots or videos to demonstrate the feature/fix. ## Related Issues For your convenience, here is a list of the aforementioned micro-PRs (each such PR just removes a similar line of code, i.e. cleans up an obsolete workaround): - [PR 8 of adore_map](eclipse-adore/adore_map#8) - [PR 7 of adore_dynamics](eclipse-adore/adore_dynamics#7) - [PR 6 of adore_planning](eclipse-adore/adore_planning#6) - [PR 13 of adore_decision_maker](eclipse-adore/adore_decision_maker#13) - [PR 15 of adore_visualizer](eclipse-adore/adore_visualizer#15) - [PR 8 of adore_simulated_vehicle](eclipse-adore/adore_simulated_vehicle#8) - [PR 4 of adore_map_conversions](eclipse-adore/adore_map_conversions#4) - [PR 5 of adore_dynamics_conversions](eclipse-adore/adore_dynamics_conversions#5) - [PR 18 of adore_if_carla](eclipse-adore/adore_if_carla#18) - [PR 7 of adore_controllers](eclipse-adore/adore_controllers#7) - [PR 6 of adore_trajectory_tracker](eclipse-adore/adore_trajectory_tracker#6) - [PR 5 of adore_mission_control](eclipse-adore/adore_mission_control#5) - [PR 6 of adore_decision_maker_infrastructure](eclipse-adore/adore_decision_maker_infrastructure#6) ## Notes for Reviewers This PR is best merged after merging the above micro-PRs. I can update the hashes of the submodules here for this PR, then. Thank you very much in advance! Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed find_package command for caches
This PR removes just one line from CMakeLists.txt (a find_package command for caches).
It had been inserted as a workaround for a building issue. This has become obsolete by commit eclipse-adore/adore_map@8d0b31a by @akoerner1 (thanks!)