Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

Conversation

@sishida
Copy link
Contributor

@sishida sishida commented Dec 11, 2019

Signed-off-by: Sarah Ishida sishida@us.ibm.com

PR for eclipse-archived/codewind#1397

Signed-off-by: Sarah Ishida <sishida@us.ibm.com>
@sishida sishida changed the title Adding info about Codewind remote (WIP) Adding info about Codewind remote Dec 11, 2019
@sishida sishida self-assigned this Dec 11, 2019
@sishida sishida requested a review from micgibso December 11, 2019 22:38
@sishida
Copy link
Contributor Author

sishida commented Dec 11, 2019

Hi, @micgibso, This PR adds information about the remote UI to the Codewind remote file that you created earlier. We aren't ready to merge yet. (I still need more info from Guy and a link from Jake.) But please let me know if you'd like any changes or if it looks good to go so far. Thanks!

Copy link
Contributor

@micgibso micgibso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sishida , This doesn't belong in the Overview topic because it's a procedure. It seems to be about adding templates (and registries(?)) when you are working with a remote deployment of Codewind, so I'd consider adding this as a new section in the working with templates topics: mdt-vsc-workingwithtemplates.md and mdt-eclipse-workingwithtemplates.md; those topics are identical so you can quite happily draft once, and add to both.

Late changes to the remote deployment of Codewind story included changing the terminology from Codewind remote to a remote deployment of Codewind so suggest changing the title to

### Entering credentials for a remote deployment of Codewind

Or maybe something more directly describing what the procedure is about, for example:

### Adding template sources to a remote deployment of Codewind

Then, link to this from the Deploying Codewind remotely overview page by adding a paragraph which says for example: You can add template sources to your remote deployment of Codewind, for more information, for VS Code, see Working with templates(mdt-vsc-workingwithtemplates.md), and for Eclipse, see Working with templates(mdt-eclipse-workingwithtemplates.md). Suggest you add this on a new line after 'To configure your remote deployment of Codewind, see Configuring your remote deployment of Codewind.', just before the Codewind remote security overview title.

I suspect this is about the GUI representation of the remote deployment of Codewind story? If so, then it definitely belongs in those Eclipse/VS Code sections.

Signed-off-by: Sarah Ishida <sishida@us.ibm.com>
Copy link
Contributor

@micgibso micgibso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@micgibso micgibso merged commit 0ad08b8 into eclipse-archived:master Dec 13, 2019
@micgibso micgibso changed the title (WIP) Adding info about Codewind remote Adding info about Codewind remote Dec 13, 2019
@sishida sishida deleted the sishida_1397_remote branch December 13, 2019 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants