This repository was archived by the owner on Nov 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Update app metrics to metrics dashboard #373
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
hhellyer
suggested changes
Feb 14, 2020
Contributor
hhellyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a little confusing in the middle between Appmetrics (the "thing" that's injected to gather the data) and the dashboard (the "thing" the user accesses to see the results).
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
hhellyer
suggested changes
Feb 14, 2020
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
hhellyer
approved these changes
Feb 17, 2020
jcockbain
pushed a commit
to jcockbain/codewind-docs
that referenced
this pull request
May 26, 2020
Update app metrics to metrics dashboard
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: micgibso MICGIBSO@uk.ibm.com
New PR for issue eclipse-archived/codewind#2137 with merge conflicts resolved.
@sujeilyfonseca @jagraj please review and advise on any further changes.