Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

Conversation

@micgibso
Copy link
Contributor

@micgibso micgibso commented Feb 14, 2020

Signed-off-by: micgibso MICGIBSO@uk.ibm.com

New PR for issue eclipse-archived/codewind#2137 with merge conflicts resolved.

@sujeilyfonseca @jagraj please review and advise on any further changes.

Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Copy link
Contributor

@hhellyer hhellyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a little confusing in the middle between Appmetrics (the "thing" that's injected to gather the data) and the dashboard (the "thing" the user accesses to see the results).

Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
Signed-off-by: micgibso <MICGIBSO@uk.ibm.com>
@micgibso micgibso merged commit fddd7db into eclipse-archived:master Feb 17, 2020
jcockbain pushed a commit to jcockbain/codewind-docs that referenced this pull request May 26, 2020
Update app metrics to metrics dashboard
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants