This repository was archived by the owner on Nov 28, 2022. It is now read-only.
Conversation
added 15 commits
January 28, 2020 09:53
sghung
approved these changes
Jan 29, 2020
Contributor
sghung
left a comment
sghung
left a comment
There was a problem hiding this comment.
Changes look good, download the PR build from https://download.eclipse.org/codewind/codewind-openapi-eclipse/testSJ/latest/ and verified that no jar signing warning shows up when installing onto eclipse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes eclipse-archived/codewind#1890
The signing jar issue was caused by calling it from a docker-build agent which is not supported by Eclipse Jenkins for now. The fix would be running only 'test' stage on a docker-build agent and run signjar on non-docker-build agent.