Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

Update to 4.2.2 to pick up node-express-server generator#83

Merged
sghung merged 1 commit intoeclipse-archived:masterfrom
keithchong:82-UpdateTo420Generator
Jan 7, 2020
Merged

Update to 4.2.2 to pick up node-express-server generator#83
sghung merged 1 commit intoeclipse-archived:masterfrom
keithchong:82-UpdateTo420Generator

Conversation

@keithchong
Copy link
Copy Markdown
Contributor

Fixes #82

Signed-off-by: Keith Chong kchong@ca.ibm.com

@keithchong keithchong requested a review from sghung November 14, 2019 18:16
@keithchong keithchong force-pushed the 82-UpdateTo420Generator branch from 10a529f to 1275af3 Compare December 3, 2019 19:02
@keithchong keithchong force-pushed the 82-UpdateTo420Generator branch from c88b6e4 to 39624a3 Compare December 17, 2019 20:49
Signed-off-by: Keith Chong <kchong@ca.ibm.com>
@keithchong keithchong force-pushed the 82-UpdateTo420Generator branch from 39624a3 to 080d904 Compare December 17, 2019 20:52
@keithchong keithchong changed the title Update to 4.2.0 to pick up node-express-server generator Update to 4.2.2 to pick up node-express-server generator Dec 17, 2019
@sghung
Copy link
Copy Markdown
Contributor

sghung commented Dec 19, 2019

I confirmed with Keith that the .classpath entry isn't necessary as it isn't required to be a plugin runtime jar. The removal in the PR is for cleanup purposes.

"jaxrs-resteasy-eap",
"spring"},
{"Node.js", "nodejs-server"},
{"Node.js", "nodejs-express-server", "nodejs-server-deprecated"},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to add the nodejs-server-deprecated? If it is going (or is) deprecated, shouldn't we stop it from showing?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the generator keeps it, we'll keep it. We try to mirror what the command line generator has. Another reason is that if someone wants to use it, they don't have to get a back-level version of the generator.

@sghung
Copy link
Copy Markdown
Contributor

sghung commented Dec 20, 2019

@keithchong I am using Eclipse 2019-12 (4.14.0) and I see compilation errors after creating a node js express server stub. A lot of errors complaining about missing semi colons. Do you see the same issue?

Also, what context root did you use to verify the results? http://127.0.0.1:32805/pets doesn't work. Also, in the automated tests, besides the verification of the files, can we call Codewind to verify the API is there (also to verify what context root should be used).

@keithchong
Copy link
Copy Markdown
Contributor Author

@sghung , the codewind build itself is ok. Those are validation errors coming from the WTP Javascript validator. Try disabling the validator on the project or the Eclipse workspace. You will not see these errors in VS Code.

What you're doing is trying to generate the server into the current Codewind project. The usability improvements will come next. This may involve not allowing the project root to be the output folder.

I want the 4.2.2 update also to take advantage of the Liberty-specific code generation for Java JAX-RS.

Copy link
Copy Markdown
Contributor

@sghung sghung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for commenting. Approving

@sghung sghung merged commit a35155c into eclipse-archived:master Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to 4.2.2 to pick up node-express-server generator, for Eclipse

2 participants