Update to 4.2.2 to pick up node-express-server generator#83
Conversation
10a529f to
1275af3
Compare
c88b6e4 to
39624a3
Compare
Signed-off-by: Keith Chong <kchong@ca.ibm.com>
39624a3 to
080d904
Compare
|
I confirmed with Keith that the .classpath entry isn't necessary as it isn't required to be a plugin runtime jar. The removal in the PR is for cleanup purposes. |
| "jaxrs-resteasy-eap", | ||
| "spring"}, | ||
| {"Node.js", "nodejs-server"}, | ||
| {"Node.js", "nodejs-express-server", "nodejs-server-deprecated"}, |
There was a problem hiding this comment.
Why do we need to add the nodejs-server-deprecated? If it is going (or is) deprecated, shouldn't we stop it from showing?
There was a problem hiding this comment.
If the generator keeps it, we'll keep it. We try to mirror what the command line generator has. Another reason is that if someone wants to use it, they don't have to get a back-level version of the generator.
|
@keithchong I am using Eclipse 2019-12 (4.14.0) and I see compilation errors after creating a node js express server stub. A lot of errors complaining about missing semi colons. Do you see the same issue? Also, what context root did you use to verify the results? http://127.0.0.1:32805/pets doesn't work. Also, in the automated tests, besides the verification of the files, can we call Codewind to verify the API is there (also to verify what context root should be used). |
|
@sghung , the codewind build itself is ok. Those are validation errors coming from the WTP Javascript validator. Try disabling the validator on the project or the Eclipse workspace. You will not see these errors in VS Code. What you're doing is trying to generate the server into the current Codewind project. The usability improvements will come next. This may involve not allowing the project root to be the output folder. I want the 4.2.2 update also to take advantage of the Liberty-specific code generation for Java JAX-RS. |
sghung
left a comment
There was a problem hiding this comment.
Thanks for commenting. Approving
Fixes #82
Signed-off-by: Keith Chong kchong@ca.ibm.com