Fix deserialization of root key id#112
Merged
Korbik merged 2 commits intoeclipse-biscuit:mainfrom Feb 11, 2025
Merged
Conversation
Korbik
approved these changes
Feb 11, 2025
Contributor
Korbik
left a comment
There was a problem hiding this comment.
Looks good to me.
Is it necessary to be integrated in a fix release ? Because the next release will be a major one with some break with the API.
For a quick fix, we may need to create a new branch to release the fix and rebase the branch from the 4.0.1 tag. Let me know what you prefer.
Contributor
Author
|
Thanks for review. I think we just merge this now and have new release when it is appropriate. I'm more interested in a release because of the fix to check the result of verification in: #108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SerializedBiscuit.SerializedBiscuitto avoid losing it when copying objects.