Skip to content

Remove incorrect @classmethod on constructors#53

Merged
divarvel merged 1 commit into
eclipse-biscuit:mainfrom
avandecreme:patch-1
Apr 24, 2026
Merged

Remove incorrect @classmethod on constructors#53
divarvel merged 1 commit into
eclipse-biscuit:mainfrom
avandecreme:patch-1

Conversation

@avandecreme
Copy link
Copy Markdown
Contributor

This confuses ty:

error[invalid-argument-type]: Argument to bound method `PrivateKey.__new__` is incorrect
   --> conftest.py:118:12
    |
118 |     return PrivateKey(private_key)
    |            ^^^^^^^^^^^^^^^^^^^^^^^ Expected `str`, found `<class 'PrivateKey'>`
    |
info: Method defined here
   --> .venv/lib/python3.13/site-packages/biscuit_auth/__init__.pyi:512:9
    |
512 |     def __new__(cls, data: str) -> PrivateKey: ...
    |         ^^^^^^^ --- Parameter declared here
    |

error[too-many-positional-arguments]: Too many positional arguments to bound method `PrivateKey.__new__`: expected 1, got 2
   --> conftest.py:118:23
    |
118 |     return PrivateKey(private_key)
    |                       ^^^^^^^^^^^
    |
info: Method signature here
   --> .venv/lib/python3.13/site-packages/biscuit_auth/__init__.pyi:512:9
    |
512 |     def __new__(cls, data: str) -> PrivateKey: ...
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |

@divarvel
Copy link
Copy Markdown
Contributor

divarvel commented Apr 23, 2026

the tests fail because of python version update. main now support 3.14, so you could try rebasing

@divarvel
Copy link
Copy Markdown
Contributor

Cool! You'll just need to sign the eclipse DCO (not a CLA). Instructions should be in CONTRIBUTING.md

@avandecreme
Copy link
Copy Markdown
Contributor Author

Done. (The process was infuriating though)

@divarvel
Copy link
Copy Markdown
Contributor

Done. (The process was infuriating though)

thank you. yeah it’s tedious. Thankfully it’s a one-time thing (and necessary to have the legal enforcement provided by the eclipse foundation)

@divarvel divarvel merged commit c0fa698 into eclipse-biscuit:main Apr 24, 2026
29 of 31 checks passed
@avandecreme avandecreme deleted the patch-1 branch April 24, 2026 09:33
@avandecreme
Copy link
Copy Markdown
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants