Load initial config file with the default values#177
Conversation
ArtiomDivak
requested review from
alexlarsson,
engelmi,
mkemel,
rhatdan and
sdunnagan
as code owners
mwperina
left a comment
mwperina
left a comment
There was a problem hiding this comment.
Please take a look at rpmbuild job error, you need to update hirte.spec.in to include default config files into RPM packages
|
So I think 2 parts are missing:
|
|
#183 should fix the error in e2e test job |
mwperina
force-pushed
the
issue-147
branch
5 times, most recently
from
d0f9107 to
7cdf025
Compare
mwperina
left a comment
mwperina
left a comment
There was a problem hiding this comment.
Patch is OK, but e2e workflow needs to be adapted to really install things into /usr/local instead of custom directory, because we require to load default configuration from /usr/local/share/[hirte|hirte-agent]/config/hirte-default.conf
ArtiomDivak
force-pushed
the
issue-147
branch
9 times, most recently
from
7ed40ee to
0276ed2
Compare
ArtiomDivak
force-pushed
the
issue-147
branch
2 times, most recently
from
10cb14d to
f78aa69
Compare
|
Depends on #182 |
mwperina
force-pushed
the
issue-147
branch
4 times, most recently
from
e0ab202 to
0567266
Compare
|
Hmm, it seems to me that debug logs are not shown in journald, strange ... |
Yarboa
left a comment
Yarboa
left a comment
There was a problem hiding this comment.
Suggestion,
Please try dnf update, and rerun the tests
Maybe we should add dnf update in test/Container file,
mwperina
force-pushed
the
issue-147
branch
6 times, most recently
from
ee5f894 to
8e7e4b2
Compare
Yarboa
left a comment
Yarboa
left a comment
There was a problem hiding this comment.
Is there a specific issue for the journald ?
Is it related to the default config files mechanism?
|
LGTM @ArtiomDivak Please rebase |
For a full description please read here eclipse-bluechi#147. For each of the node types [hirte, agent] hirte will get the default config from the default files located in /usr/shar/hirte/{hirte|agent} into the hashmap and only after that it will get the custome config that the usr changed Fixes: eclipse-bluechi#147 Signed-off-by: Artiom Divak <adivak@redhat.com>
4 participants
For a full description please read here
#147.
For each of the node types [hirte, agent] hirte
will get the default config from the default
files located in /usr/shar/hirte/{hirte|agent}
into the hashmap and only after that it will
get the custome config that the usr changed
Fixes: #147
Signed-off-by: ArtiomDivak adivak@redhat.com