make the cmake error parser public API #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Weber <11367029+15knots@users.noreply.github.com> Change-Id: I816b8ee5852e6b25011a611c07c54d0a814a74d8
Signed-off-by: Martin Weber <11367029+15knots@users.noreply.github.com> Change-Id: Ibb98c420e956efec1262fb59af6e1775be67d957
Signed-off-by: Martin Weber <11367029+15knots@users.noreply.github.com> Change-Id: Ibb98c420e956efec1262fb59af6e1775be67d957
Change-Id: Ibbb52cebc4fd60deb3ff72c0725adce219f1f7e7
jonahgraham
reviewed
Sep 13, 2022
Member
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
LGTM - just missing @since tags for the API tooling. IIRC you had trouble getting that to work properly in the past, if that is still the case I can add the tags, let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.