fix: release script fixes#2117
Merged
Merged
Conversation
Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
mkuznyetsov
requested review from
a team,
MichalMaler,
rkratky and
themr0c
as code owners
|
Click here to review and test in web IDE: |
sleshchenko
approved these changes
Sep 14, 2021
Member
sleshchenko
left a comment
sleshchenko
left a comment
There was a problem hiding this comment.
All changes seem to be meaningful but I haven't tested
themr0c
approved these changes
Sep 15, 2021
|
Click here to review and test in web IDE: |
Contributor
|
I am not sure what would be the right way to test these steps. They have direct impact on the repositories. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
Fix several mistakes, that caused the release script to not work properly.
Add Mattermost notifications for the release job, to better observe the job's success or fails
What issues does this pull request fix or reference?
Specify the version of the product this pull request applies to
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.