fix: fix case of kubectl create secret tls #2865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚡️ Deploying pull request preview... |
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
Contributor
|
if this fix is for any version of Che, it would be better to merge it into |
TLS does not work.
Contributor
Author
|
Oh, sorry- I created the PR with the "edit this page" link and I didn't notice where it landed. Fixed. |
Contributor
|
no worries! |
Contributor
|
@alexveecle it seems you'll need to validate your mail + agree with terms & conditions of the eclipse foundation |
Contributor
Author
|
Yeah, I saw the ECA failing check. Cannot I just waive all rights over this PR? I'll go create an Eclipse account... |
Contributor
Author
Done |
ibuziuk
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
kubectl create secret TLSdoes not work, must be case-sensitive.What issues does this pull request fix or reference?
None.
Specify the version of the product this pull request applies to
Any.
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.