Conversation
vinokurig
requested review from
a team,
deerskindoll,
gtrivedi88 and
mkuznyetsov
as code owners
|
🎊 Navigate the preview: https://69d4bc37214254dc709a980e--eclipse-che-docs-pr.netlify.app 🎊 |
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
vinokurig
force-pushed
the
che-23505
branch
3 times, most recently
from
316442c to
06207b2
Compare
svor
left a comment
svor
left a comment
There was a problem hiding this comment.
@vinokurig Since we have eclipse-che/che#23785, I think we shouldn't remove information about OAuth 2.0 deprecation. WDYT?
|
@gtrivedi88 could you please take a look? |
I don't think we need this notification after we remove instructions about the deprecated Azure DevOps oauth application. If customer still uses the old application they would not need the instructions, it will still work with the eclipse-che/che-server#985 pull request. |
There was a problem hiding this comment.
looks good, some suggestions
@svor Will we be backporting this to 3.27?
| OAuth 2.0 isn't supported on Azure DevOps Server, see link:https://learn.microsoft.com/en-us/azure/devops/integrate/get-started/authentication/oauth?view=azure-devops[the documentation page]. | ||
| [IMPORTANT] | ||
| Azure DevOps OAuth 2.0 is deprecated and no longer accepts new registrations, with full deprecation planned for 2026. See link:https://learn.microsoft.com/en-us/azure/devops/integrate/get-started/authentication/oauth?view=azure-devops[the documentation page]. | ||
| . Set up an application in Microsoft Entra ID. |
There was a problem hiding this comment.
The assembly title (line 8), :description: (line 2), :navtitle: (line 4), and [id=...] (line 7) still reference "Microsoft Azure DevOps Services" but the procedures now use Microsoft Entra ID. Update these to align with the new flow.
Also: the two removed [IMPORTANT] blocks mentioned OAuth 2.0 deprecation and Azure DevOps Server limitations. Should the assembly introduction note that Microsoft Entra ID replaces the deprecated OAuth 2.0 app registration?
There was a problem hiding this comment.
The assembly title (line 8), :description: (line 2), :navtitle: (line 4), and [id=...] (line 7) still reference "Microsoft Azure DevOps Services" but the procedures now use Microsoft Entra ID. Update these to align with the new flow.
Configuring OAuth 2.0 for Microsoft Azure DevOps Services is still relevant because we do not mention the specific oauth application here. OAuth 2.0 here is a general name for oauth applications (Azure DevOps oauth application or Microsoft OIDC oauth application).
There was a problem hiding this comment.
Also: the two removed [IMPORTANT] blocks mentioned OAuth 2.0 deprecation and Azure DevOps Server limitations. Should the assembly introduction note that Microsoft Entra ID replaces the deprecated OAuth 2.0 app registration?
These instructions are supposed to help configure OAuth for Azure DevOps. Creating new Azure OAuth apps is no longer available, so why is there a need to mention it?
There was a problem hiding this comment.
You're right that the procedures should focus on the new Entra ID path only. However, @svor raised a valid concern via eclipse-che/che#23785, existing users with old Azure DevOps OAuth apps need to know it's deprecated.
Can we add a brief [NOTE] in the assembly introduction (not in the procedures)?
[NOTE]
====
Microsoft Entra ID replaces the deprecated Azure DevOps OAuth 2.0 app registration, which no longer accepts new registrations. If you have an existing Azure DevOps OAuth app, migrate to Microsoft Entra ID.
====This addresses the migration concern without cluttering the procedure steps. WDYT?
There was a problem hiding this comment.
done, added the note
|
@gtrivedi88 thanks for the review. It's for 3.28 |
…osoft-azure-devops-services-oauth-app.adoc Co-authored-by: Gaurav Trivedi <90042568+gtrivedi88@users.noreply.github.com>
…osoft-azure-devops-services-oauth-app.adoc Co-authored-by: Gaurav Trivedi <90042568+gtrivedi88@users.noreply.github.com>
…oft-azure-devops-services-oauth-app-secret.adoc Co-authored-by: Gaurav Trivedi <90042568+gtrivedi88@users.noreply.github.com>
…oft-azure-devops-services-oauth-app-secret.adoc Co-authored-by: Gaurav Trivedi <90042568+gtrivedi88@users.noreply.github.com>
|
@gtrivedi88 Could you please take a look on my last comment? |
Let me know what you think |
|
@gtrivedi88 I ment this thread #3036 (comment) |
|
@gtrivedi88 @svor Sorry for confusion, did not see the latest comment in the thread, addressed the comment. |
…-microsoft-azure-devops-services-oauth-app-secret.adoc
3 participants
What does this pull request change?
Update Azure DevOps Oauth configuration instructions
What issues does this pull request fix or reference?
eclipse-che/che#23505
Specify the version of the product this pull request applies to
next
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.