Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
/retest |
pkg/common/utils/utils.go
Outdated
| } | ||
|
|
||
| func FindAvailableDelimiter(s string) string { | ||
| delimiters := []string{",", "|", ";", ":", "#", "\t"} |
There was a problem hiding this comment.
Perhaps we should move the delimiter list to a package-level constant for better visibility and reuse.
Also, since the order defines the precedence of delimiter selection, it might be worth documenting this behavior explicitly.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohanKanojia, tolusha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
/retest |
1 similar comment
|
/retest |
|
@tolusha: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What does this PR do?
These changes fix a bug where usernames or group names containing commas would break the advanced authorization config, since commas were hardcoded as the delimiter. Now the operator automatically picks a safe delimiter (from
,, |, ;, :, #, \t) that doesn't conflict with the actual values, and communicates the chosen delimiter to the server via a new env var. It also allows manual delimiter override through ExtraProperties and returnsan error if no safe delimiter can be found.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-10255
Related to
eclipse-che/che-server#967
How to test this PR?
N/A
Common Test Scenarios
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.