-
Notifications
You must be signed in to change notification settings - Fork 77
Fix error when parsing SSH url without port. #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/retest |
1 similar comment
|
/retest |
|
Verified on Eclipse Che with |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, tolusha, vinokurig The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build 3.22 :: server_3.x/408: Console, Changes, Git Data |
|
Build 3.22 :: sync-to-downstream_3.x/9337: Console, Changes, Git Data |
|
Build 3.22 :: push-latest-container-to-quay_3.x/5181: Console, Changes, Git Data |
|
Build 3.22 :: get-sources-rhpkg-container-build_3.x/9485: server : 3.x :: Build 67749452 : quay.io/devspaces/server-rhel9:3.22-6 |
|
Build 3.22 :: update-digests_3.x/9287: Console, Changes, Git Data |
|
Build 3.22 :: server_3.x/408: Upstream sync done; /DS_CI/sync-to-downstream_3.x/9337 triggered |
|
Build 3.22 :: operator-bundle_3.x/4913: Console, Changes, Git Data |
|
Build 3.22 :: sync-to-downstream_3.x/9338: Console, Changes, Git Data |
|
Build 3.22 :: push-latest-container-to-quay_3.x/5182: Console, Changes, Git Data |
|
Build 3.22 :: copyIIBsToQuay/3002: Console, Changes, Git Data |
|
Build 3.22 :: sync-to-downstream_3.x/9338: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/9486 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.22 :: operator-bundle_3.x/4913: Upstream sync done; /DS_CI/sync-to-downstream_3.x/9338 triggered |
|
Build 3.22 :: dsc_3.x/2058: Console, Changes, Git Data |
|
Build 3.22 :: update-digests_3.x/9287: Detected new images: rebuild operator-bundle |
|
Build 3.22 :: dsc_3.x/2058: 3.22.0-CI |
What does this PR do?
When we parse SSH urls, we extract the server url from it by extracting the string after
ssh://git@to:<port>/.... If the provider url does not contain port, e.g.ssh://git@<hostname>/user/repoan error occurs.Rework the extract server functions to respect urls without port.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-8301
How to test this PR?
ssh://git@<hostname>/user/repoe.gssh://git@bitbucket-server/user/repo.git.See: the url is resolved and workspace starts.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.