Skip to content

Conversation

@vinokurig
Copy link
Contributor

What does this PR do?

When we parse SSH urls, we extract the server url from it by extracting the string after ssh://git@ to :<port>/.... If the provider url does not contain port, e.g. ssh://git@<hostname>/user/repo an error occurs.

Rework the extract server functions to respect urls without port.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-8301

How to test this PR?

  1. Add an SSH key to the user namespace.
  2. Start a workspace from an SSH url in format ssh://git@<hostname>/user/repo e.g ssh://git@bitbucket-server/user/repo.git.

See: the url is resolved and workspace starts.

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@artaleks9
Copy link
Contributor

/retest

1 similar comment
@vinokurig
Copy link
Contributor Author

/retest

@artaleks9
Copy link
Contributor

Verified on Eclipse Che with quay.io/eclipse/che-server:pr-810 - the functionality works properly

@openshift-ci
Copy link

openshift-ci bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit ab338ce into main May 28, 2025
29 checks passed
@vinokurig vinokurig deleted the CRW-8301 branch May 28, 2025 08:24
@devspacesbuild
Copy link

Build 3.22 :: server_3.x/408: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.22 :: server_3.x/408: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/9337 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.22 :: copyIIBsToQuay/3002: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.22 :: sync-to-downstream_3.x/9338: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/9486 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devspacesbuild
Copy link

Build 3.22 :: operator-bundle_3.x/4913: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/9338 triggered

@devspacesbuild
Copy link

Build 3.22 :: dsc_3.x/2058: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.22 :: update-digests_3.x/9287: SUCCESS

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.x/4913 triggered

@devspacesbuild
Copy link

Build 3.22 :: dsc_3.x/2058: SUCCESS

3.22.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants