Skip to content

Restore the dependencies on creating a C# project#10405

Merged
azatsarynnyy merged 4 commits intomasterfrom
che-10047
Jul 25, 2018
Merged

Restore the dependencies on creating a C# project#10405
azatsarynnyy merged 4 commits intomasterfrom
che-10047

Conversation

@azatsarynnyy
Copy link
Copy Markdown
Member

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Fixes restoring the dependencies on creating a C# project

What issues does this PR fix or reference?

#10047

Release Notes

Docs PR

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy
Copy link
Copy Markdown
Member Author

ci-test

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Jul 12, 2018
@riuvshin
Copy link
Copy Markdown
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10405
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Copy link
Copy Markdown

@dkulieshov dkulieshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wsPath that you are using potentially may be not a project path but a project item path. For example project path may be /projects/p1 and wsPath will be /projects/p1/pom.xml

@dkulieshov
Copy link
Copy Markdown

I think we should use something like org.eclipse.che.api.project.server.ProjectManager#getClosest to get real project and then get its workspace path. What do you think?

@azatsarynnyy
Copy link
Copy Markdown
Member Author

@dkuleshov thank you for pointing this out! I've updated the PR.

@azatsarynnyy
Copy link
Copy Markdown
Member Author

ci-test

@riuvshin
Copy link
Copy Markdown
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10405
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vkuznyetsov vkuznyetsov mentioned this pull request Jul 17, 2018
39 tasks
…g the dependencies often takes > 30 sec.

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy
Copy link
Copy Markdown
Member Author

During testing this PR with QA team it's appeared that 30 sec. isn't enough to initialize C# LS including restoring project's dependencies.
@SkorikSergey I've increased the timeout for initializing LS. Could you please check it again?

@SkorikSergey
Copy link
Copy Markdown
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/472/) doesn't show any regression against this Pull Request.

@azatsarynnyy azatsarynnyy merged commit 3467b2e into master Jul 25, 2018
@azatsarynnyy azatsarynnyy deleted the che-10047 branch July 25, 2018 11:59
@benoitf benoitf added this to the 6.9.0 milestone Jul 25, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 25, 2018
@azatsarynnyy
Copy link
Copy Markdown
Member Author

Thank you @SkorikSergey for your assistance in checking this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement A feature request - must adhere to the feature request template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants