Parse THEIA_PORT environment variable#10511
Merged
garagatyi merged 1 commit intoeclipse-che:masterfrom Jul 24, 2018
Merged
Conversation
benoitf
added
status/code-review
benoitf
approved these changes
Jul 23, 2018
mmorhun
approved these changes
Jul 24, 2018
dockerfiles/theia/src/start.sh
Outdated
| theia_port_number_regexp='^[0-9]+$' | ||
| if ! [[ "$THEIA_PORT" =~ $theia_port_number_regexp ]]; then | ||
| # THEIA_PORT contains something other than a number | ||
| theia_port_uri_regexp='^tcp://[0-9a-zA-Z.]+:[0-9]+$' |
Contributor
There was a problem hiding this comment.
I would name it like theia_port_tcp_uri_regexp because of hardcoded value.
mmorhun
removed
the
kind/question
benoitf
added
the
kind/question
Parse THEIA_PORT environment variable in Theia start.sh script to prevent failure of Theia start on k8s when there is a k8s service "theia" and k8s injects THEIA_PORT environment variable with a value such as tcp://19.19.191.19:3000 Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com> Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
garagatyi
force-pushed
the
parseTheiaPort
branch
from
0dd7edf to
39ed730
Compare
benoitf
removed
the
status/code-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Parse THEIA_PORT environment variable in Theia start.sh script
to prevent failure of Theia start on k8s when there is a k8s
service "theia" and k8s injects THEIA_PORT environment variable
with a value such as tcp://19.19.191.19:3000
What issues does this PR fix or reference?
Related to service discovery in Workspace.Next #9913
Release Notes
Docs PR