Selenium: Add new test method to the 'PullRequestPluginTest' by artaleks9 · Pull Request #11128 · eclipse-che/che

artaleks9 · 2018-09-09T14:24:34Z

What does this PR do?

Update the selenium test PullRequestPluginTest
- add new test method createPullRequestToNonDefaultBranch() to the test class
- rework the switchingBetweenProjects() test method
- rework and rename the createPullRequest() test method
- refactor code
Add the method 'clickRefreshContributionBranchButton()' to the PullRequestPanel
Add the id selector to the web element in the ContributePartViewImpl
Delete the 'try/catch' from the PullRequestPluginWithForkTest related to close the issue

What issues does this PR fix or reference?

#10000

…lRequestPlaginTest'

…equestPanel'

…ed to close the issue

artaleks9 · 2018-09-09T14:24:48Z

ci-test

riuvshin · 2018-09-09T19:46:25Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:11128
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-09-10T14:11:29Z

...um/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/PullRequestPanel.java

    static final String PULL_REQUEST_BTN = "gwt-debug-partButton-Pull Request";
    static final String BRANCH_NAME =
        "//div[text()='Branch name:']/following-sibling::div//span/label[text()='%s']";
+    static final String REFRESH_BRANCH_BUTTON = "gwt-debug-refreshContributionBranchButton";


Is it button name or id? Could you express it in the constant name to make it clear?

Yes, you're right.
Need to correct -> REFRESH_BRANCH_BUTTON_ID

dmytro-ndp · 2018-09-10T14:13:55Z

...um/che-selenium-test/src/main/java/org/eclipse/che/selenium/pageobject/PullRequestPanel.java


+  /** Click 'refresh contribution branch name' button on the 'Pull Request' panel */
+  public void clickRefreshContributionBranchButton() {
+    seleniumWebDriverHelper.waitAndClick(refreshBranchListButton);


refreshBranchListButton variable name hasn't completely agreed with button name expressed in method name refreshContributionBranchButton

dmytro-ndp · 2018-09-10T14:40:49Z

...nium/che-selenium-test/src/test/java/org/eclipse/che/selenium/git/PullRequestPluginTest.java

-  private static final String NEW_BRANCH = generate("branch-", 8);
+  private static final String DEV_BRANCH_NAME = generate("dev-", 4);
+  private static final String BASE_BRANCH_NAME = generate("contrib-", 4);
+  private static final String NEW_BRANCH_NAME = generate("branch-", 8);


NEW_BRANCH_NAME = generate("new-", 4); looks more suitable here

dmytro-ndp · 2018-09-10T15:23:07Z

...nium/che-selenium-test/src/test/java/org/eclipse/che/selenium/git/PullRequestPluginTest.java

+            "%s wants to merge 1 commit into %s\n" + "from %s",
+            gitHubUsername, BASE_BRANCH_NAME, DEV_BRANCH_NAME);
+    seleniumWebDriverHelper.waitTextContains(
+        By.xpath("//div[@class='TableObject-item TableObject-item--primary']"), pullHeaderText);


It's better to name //div[@class='TableObject-item TableObject-item--primary'] somehow to understand it's propose.

dmytro-ndp · 2018-09-10T15:45:40Z

...nium/che-selenium-test/src/test/java/org/eclipse/che/selenium/git/PullRequestPluginTest.java

+    pullRequestPanel.waitStatusOk(PULL_REQUEST_ISSUED);
+    pullRequestPanel.waitMessage(PULL_REQUEST_CREATED);
+
+    // check the pull header on the GitHub page


it's not just pull header, but Pull Request header

dmytro-ndp · 2018-09-10T15:49:15Z

IMHO checking pull request through the GitHub API by using is more reliably and safe method compare to getting to GitHub pull request web page and checking web elements state by it's xpath.
We could use org.kohsuke.github.GHRepository.getPullRequest() method for this propose.

artaleks9 · 2018-09-11T12:12:41Z

OK, it's a good idea

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

dmytro-ndp · 2018-09-21T16:32:54Z

ci-test

riuvshin · 2018-09-21T19:48:04Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11128
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-09-21T20:08:12Z

ci-test

riuvshin · 2018-09-22T01:06:59Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11128
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

dmytro-ndp · 2018-09-26T17:01:25Z

ci-test

riuvshin · 2018-09-26T20:00:59Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11128
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

dmytro-ndp · 2018-10-01T10:33:18Z

@artaleks9: please, review new changes.

dmytro-ndp · 2018-10-01T12:04:25Z

ci-test

artaleks9 · 2018-10-01T12:07:07Z

Looks good for me

riuvshin · 2018-10-01T15:08:03Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11128
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

…-che#11128) * Add new test method 'createPullRequestToNonDefaultBranch' to the 'PullRequestPlaginTest' * Add the method 'clickRefreshContributionBranchButton()' to the 'PullRequestPanel' * Add the id selector to the web element in the 'ContributePartViewImpl' * Delete the 'try/catch' from the 'PullRequestPluginWithForkTest' related to close the issue * Read test pull request info by using kohsuke library * Ensure 'Git Contribute' preference is set to default value after the test execution Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

artaleks9 added 4 commits September 9, 2018 17:11

Add new test method 'createPullRequestToNonDefaultBranch' to the 'Pul…

51b7073

…lRequestPlaginTest'

Add the method 'clickRefreshContributionBranchButton()' to the 'PullR…

7a67758

…equestPanel'

Add the id selector to the web element in the 'ContributePartViewImpl'

8a3fcfd

Delete the 'try/catch' from the 'PullRequestPluginWithForkTest' relat…

e12e815

…ed to close the issue

artaleks9 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. team/che-qe labels Sep 9, 2018

artaleks9 requested review from RomanNikitenko, SkorikSergey and dmytro-ndp September 9, 2018 14:24

artaleks9 requested review from Ohrimenko1988, musienko-maxim and vparfonov as code owners September 9, 2018 14:24

RomanNikitenko approved these changes Sep 10, 2018

View reviewed changes

SkorikSergey approved these changes Sep 10, 2018

View reviewed changes

dmytro-ndp reviewed Sep 10, 2018

View reviewed changes

dmytro-ndp changed the title ~~Selenium: Add new test method to the 'PullRequestPlaginTest'~~ Selenium: Add new test method to the 'PullRequestPluginTest' Sep 12, 2018

Dmytro Nochevnov added 2 commits September 21, 2018 19:31

Read test pull request info by using kohsuke library

c78b587

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Merge remote-tracking branch 'origin/master' into che#10000

f869a50

Dmytro Nochevnov added 2 commits September 24, 2018 13:28

Restore creation of workspace from PR facroy

f65b4c4

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Merge remote-tracking branch 'origin/master' into che#10000

444eb3a

musienko-maxim approved these changes Sep 26, 2018

View reviewed changes

Dmytro Nochevnov added 3 commits September 26, 2018 19:25

Ensure 'Git Contribute' preference is set to default value

2a619ef

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Minor Fixup according to review

ced16de

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Rearange the tests to avoid intersections

c857dd2

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Dmytro Nochevnov added 2 commits October 1, 2018 12:43

Merge remote-tracking branch 'origin/master' into che#10000

598b71b

Restore Preferencse#clickOnShowArtifactCheckBox() method

5aee59c

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Reuse seleniumWebDriverHelper.getAction()

a09e0ca

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

dmytro-ndp approved these changes Oct 1, 2018

View reviewed changes

dmytro-ndp merged commit e5ca2e8 into master Oct 1, 2018

dmytro-ndp deleted the che#10000 branch October 1, 2018 16:21

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 1, 2018

benoitf added this to the 6.12.0 milestone Oct 1, 2018

Conversation

artaleks9 commented Sep 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What issues does this PR fix or reference?

Uh oh!

artaleks9 commented Sep 9, 2018

Uh oh!

riuvshin commented Sep 9, 2018

Uh oh!

dmytro-ndp Sep 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

artaleks9 Sep 10, 2018

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Sep 10, 2018

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Sep 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Sep 10, 2018

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp Sep 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmytro-ndp commented Sep 10, 2018

Uh oh!

artaleks9 commented Sep 11, 2018

Uh oh!

dmytro-ndp commented Sep 21, 2018

Uh oh!

riuvshin commented Sep 21, 2018

Uh oh!

dmytro-ndp commented Sep 21, 2018

Uh oh!

riuvshin commented Sep 22, 2018

Uh oh!

dmytro-ndp commented Sep 26, 2018

Uh oh!

riuvshin commented Sep 26, 2018

Uh oh!

dmytro-ndp commented Oct 1, 2018

Uh oh!

dmytro-ndp commented Oct 1, 2018

Uh oh!

artaleks9 commented Oct 1, 2018

Uh oh!

riuvshin commented Oct 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

artaleks9 commented Sep 9, 2018 •

edited

Loading

dmytro-ndp Sep 10, 2018 •

edited

Loading

dmytro-ndp Sep 10, 2018 •

edited

Loading

dmytro-ndp Sep 10, 2018 •

edited

Loading