Merged
Conversation
Use verbacio config to define max_body_size for request entity. I'ts prevent fail Theia image build if was applied extension with big size. Redirect Verbaccio logs to the file with help config. We detach Verbaccio process so input from this application become mixed with Theia image build output. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
benoitf
approved these changes
Sep 17, 2018
mmorhun
approved these changes
Sep 17, 2018
benoitf
added
the
kind/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use verbacio config to define max_body_size for request entity. I'ts prevent fail theia image build if was applied theia extension with big size.
Redirect verbaccio logs to file with help config. We detach Verbaccio process, so input from this application became mixed with Theia image build output:
#11229
Little useful fix up for README.md file.
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com
What issues does this PR fix or reference?
#11229