Selenium: stabilize FindUsagesBaseOperationTest selenium test#11365
Merged
SkorikSergey merged 5 commits intomasterfrom Sep 26, 2018
Merged
Selenium: stabilize FindUsagesBaseOperationTest selenium test#11365SkorikSergey merged 5 commits intomasterfrom
SkorikSergey merged 5 commits intomasterfrom
Conversation
SkorikSergey
added
status/code-review
SkorikSergey
requested review from
Ohrimenko1988 and
musienko-maxim
as code owners
dmytro-ndp
reviewed
Sep 26, 2018
| public void clickOnIconNodeInFindUsagesPanel(String nameNode) { | ||
| seleniumWebDriverHelper.waitAndClick( | ||
| By.xpath(format(Locators.FIND_USAGES_ICON_NODE, nameNode))); | ||
| WaitUtils.sleepQuietly(500, TimeUnit.MILLISECONDS); |
Contributor
There was a problem hiding this comment.
Could you, please, leave a comment in the code with explanation why do we need to wait here for 500 millisecs?
dmytro-ndp
reviewed
Sep 26, 2018
| public void selectNodeInFindUsagesByDoubleClick(String node) { | ||
| seleniumWebDriverHelper.moveCursorToAndDoubleClick( | ||
| By.xpath(format(Locators.FIND_USAGES_NODE, node))); | ||
| WaitUtils.sleepQuietly(500, TimeUnit.MILLISECONDS); |
Contributor
There was a problem hiding this comment.
Could you, please, leave a comment in the code with explanation why do we need to wait here for 500 millisecs?
dmytro-ndp
reviewed
Sep 26, 2018
| projectExplorer.openItemByVisibleNameInExplorer("AppController.java"); | ||
|
|
||
| // Check basic operations of the 'find usages' panel | ||
| // Check basic operations of the FindUsages panel |
Contributor
There was a problem hiding this comment.
FindUsages -> Find Usages
dmytro-ndp
reviewed
Sep 26, 2018
| findUsages.waitSelectedElementInFindUsagesPanel("numGuessByUser"); | ||
|
|
||
| // Check nodes in the 'find usages' panel by 'double click' and click on the icon node | ||
| // Check nodes in the FindUsages panel by 'double click' and click on the icon node |
Contributor
There was a problem hiding this comment.
Code will be slightly clearer if we put comment click on the icon node at the proper place in the code below.
dmytro-ndp
approved these changes
Sep 26, 2018
artaleks9
approved these changes
Sep 26, 2018
SkorikSergey
removed
the
status/code-review
nickboldt
pushed a commit
to nickboldt/che
that referenced
this pull request
Oct 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reworks use steps in FindUsagesBaseOperationTest selenium test in part that checks working with the "Find Usages" panel by clicks. Also were added timeout after every click on node.
What issues does this PR fix or reference?
#11171