Skip to content

Comments

[Test] Fix workspace deletion timeout in TestWorkspaceUtil#23406

Merged
dmytro-ndp merged 1 commit intoeclipse-che:mainfrom
martinszuc:CRW-8596
Apr 9, 2025
Merged

[Test] Fix workspace deletion timeout in TestWorkspaceUtil#23406
dmytro-ndp merged 1 commit intoeclipse-che:mainfrom
martinszuc:CRW-8596

Conversation

@martinszuc
Copy link
Contributor

@martinszuc martinszuc commented Apr 9, 2025 •
edited
Loading

Example wait of polling in waitWorkspaceStatus() function which uses same polling technique.

This wait was missing in the deleteWorkspaceByName() function, fixed by this pr.

What does this PR do?

Added missing wait await this.driverHelper.wait(this.polling);

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-8596

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@martinszuc
[Test] Fix workspace deletion timeout in TestWorkspaceUtil
73c67e2 
Signed-off-by: Martin Szuc <mszuc@redhat.com>
@martinszuc
Copy link
Contributor Author

martinszuc commented Apr 9, 2025

My successful run containing the wait:

          ▼ ApiUrlResolver.obtainUserNamespace - admin-devspaces
            ‣ DriverHelper.getDriver
          ▼ TestWorkspaceUtil.stopWorkspaceByName - empty-ufiw stopped successfully
          ▼ TestWorkspaceUtil.deleteWorkspaceByName - empty-ufiw
          ▼ ApiUrlResolver.obtainUserNamespace - admin-devspaces
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
            ‣ DriverHelper.wait - (1000 milliseconds)
            ‣ DriverHelper.getDriver
          ▼ TestWorkspaceUtil.deleteWorkspaceByName - empty-ufiw deleted successfully
          ▼     at /home/mszuc/projects/che/tests/e2e/specs/MochaHooks.ts:39:12 - delete workspace name
          ▼ KubernetesCommandLineToolsExecutor.loginToOcp - oc - login to the "OC" client.
          ▼ KubernetesCommandLineToolsExecutor.getServerUrl - oc - get server api url.
          ▼ KubernetesCommandLineToolsExecutor.isUserLoggedIn - oc
          ▼ ShellExecutor.executeCommand - oc whoami && oc whoami --show-server=true
admin
https://api.ocp418-mszuc.crw-qe.com:6443
          ▼ KubernetesCommandLineToolsExecutor.getServerUrl - oc - get server api url.
          ▼ KubernetesCommandLineToolsExecutor.loginToOcp - oc - user already logged
          ▼ ShellExecutor.executeCommand - oc patch checluster/devspaces -n openshift-devspaces --type=merge -p '{"spec":{"devEnvironments":{"disableContainerBuildCapabilities":false}}}'
checluster.org.eclipse.che/devspaces patched (no change)


  4 passing (2m)

Test output from original issue:

19:37:33            ▼ ApiUrlResolver.obtainUserNamespace - admin-devspaces
19:37:33              ‣ DriverHelper.getDriver
19:37:33            ▼ TestWorkspaceUtil.stopWorkspaceByName - empty-txee stopped successfully
19:37:33            ▼ TestWorkspaceUtil.deleteWorkspaceByName - empty-txee
19:37:33            ▼ ApiUrlResolver.obtainUserNamespace - admin-devspaces
19:37:33              ‣ DriverHelper.getDriver
19:37:34              ‣ DriverHelper.getDriver
19:37:34              ‣ DriverHelper.getDriver
19:37:34              ‣ DriverHelper.getDriver
19:37:34              ‣ DriverHelper.getDriver
19:37:34              ‣ DriverHelper.getDriver
19:37:34              ‣ DriverHelper.getDriver
19:37:34              ‣ DriverHelper.getDriver
19:37:34              ‣ DriverHelper.getDriver
19:37:34              ‣ DriverHelper.getDriver
19:37:34              ‣ DriverHelper.getDriver
19:37:34              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:35              ‣ DriverHelper.getDriver
19:37:36              ‣ DriverHelper.getDriver
19:37:36              ‣ DriverHelper.getDriver
19:37:36              ‣ DriverHelper.getDriver
19:37:36              ‣ DriverHelper.getDriver
19:37:36              ‣ DriverHelper.getDriver
19:37:36              ‣ DriverHelper.getDriver
19:37:36              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:37              ‣ DriverHelper.getDriver
19:37:38              ‣ DriverHelper.getDriver
19:37:38      1) "after all" hook: Stop and delete the workspace by API for "Verify container image can be used in a pod"
19:37:38    [ERROR] CheReporter runner.on.fail: Test podman build container functionality  "after all" hook: Stop and delete the workspace by API for "Verify container image can be used in a pod" failed after 4403ms
19:37:38              ‣ FullTitle:Test podman build container functionality  "after all" hook: Stop and delete the workspace by API for "Verify container image can be used in a pod"
19:37:38              ‣ Function.sanitizeTitle
19:37:38              ‣ FullTitleSanitized:Test_podman_build_container_functionality__after_all_hook-_Stop_and_delete_the_workspace_by_API_for_Verify_container_image_can_be_used_in_a_pod
19:37:38              ‣ TestTitle:"after all" hook: Stop and delete the workspace by API for "Verify container image can be used in a pod"
19:37:38              ‣ Function.sanitizeTitle
19:37:38              ‣ TestTitleSanitized:after_all_hook-_Stop_and_delete_the_workspace_by_API_for_Verify_container_image_can_be_used_in_a_pod
19:37:38              ‣ DriverHelper.getDriver
19:37:38  
19:37:38  
19:37:38    4 passing (2m)
19:37:38    1 failing

@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Apr 9, 2025

Great job, @martinszuc !

dmytro-ndp
dmytro-ndp approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed https://jenkins-csb-crwqe-main.dno.corp.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/35250/console

PR looks good to merge.

@dmytro-ndp dmytro-ndp merged commit fcf5867 into eclipse-che:main Apr 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim musienko-maxim is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martinszuc @dmytro-ndp