K8s multiuser helm#8973
Conversation
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@garagatyi I agree with you in general but keeping these files in |
|
@riuvshin I don't think it will be integrated with the CLI. The same for OS. Admins would expect to deploy Che with k8s/OS dependent flows, not with a CLI that runs inside of docker. |
|
@garagatyi agree but I don't think that we should block this PR for this. We can discuss on the proper issue where we should move the files because I don't think we have an agreement yet. And yes CLI extension to support OpenShift and k8s has been delayed/cancelled in favor of minishift addon and helm. |
|
@l0rd I didn't mean that files placement topic is blocking this PR. Just started this conversation since it is tightly related to the PR. Sure we can merge files in the current place and then move it if needed. |
|
@benoitf Can you review this PR? |
|
I'm been following @guydaichs' work on this PR. I actually saw the multiuser deployment in action. Looks good to me 👍 |
|
@guydaichs @perspectivus1 @garagatyi @l0rd here #8982 we are doing some adjustments in K8s files can you take a look and let us know if you see any issues? |
|
FYI I am testing that locally right now. I will comment later today. |
fix instructions
l0rd
left a comment
There was a problem hiding this comment.
I have tested and worked just fine. Great job @guydaichs! We can merge it tomorrow.
In the meantime can you please add license headers to the files that don't have it and add a newline at the end of a couple of files that don't have it (keycloak-configure-job.yaml and requirements.yaml).
|
@guydaichs do you want something to add to this PR or you want to merge it? Are you going to squash commits or commiters can do that for you? |
Signed-off-by: Guy Daich <guy.daich@sap.com>
|
@l0rd - I added license headers. |
|
@guydaichs thanks |
Signed-off-by: Guy Daich <guy.daich@sap.com>
What does this PR do?
Adds helm charts for deployment of Multi-User Che on Kubernetes (minikube).
Reuses images provided with #8819 (thanks @eivantsov !).
Multi/Single user is configurable with helm values (global.multiuser).
Orchestration of deployment is performed with init-containers.
Post-Installation configuration is performed with Jobs.
KeyCloak can be served from a dedicated host, or a host shared with master (/auth).
Test PR
Follow instructions to set up minikube, helm, tiller & deploy Che.
What issues does this PR fix or reference?
This PR is part of kubernetes infrastructure epic #5908.
Release Notes
Docs PR
readme