cli: performance app async tasks fix.#331
Merged
eboasson merged 1 commit intoMay 11, 2026
Merged
Conversation
eboasson
reviewed
May 11, 2026
Contributor
eboasson
left a comment
eboasson
left a comment
There was a problem hiding this comment.
I don't quite understand what the benefit of the additional create_task calls is: isn't that already covered by process_ddsperf using tasks to do work in the background?
Contributor
|
(P.S.: the updated version does work fine on python 3.14, so it does close the issue. I just don't understand it, I guess.) |
eboasson
approved these changes
May 11, 2026
Contributor
eboasson
left a comment
eboasson
left a comment
There was a problem hiding this comment.
Approved on reconsideration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync performance app with python3.11+ (closes #328)