fix: change callbackAddress in ContractAgreementMessage and ContractOfferMessage #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I would kindly ask you to wait with PRs after raising an issue. Thanks! I left a comment in the issue, see here. |
Contributor
Author
|
Seems that leaving the In this case i would convert this issue in order to add the
WDYT? which they have a potential follow-up |
juliapampus
approved these changes
Jun 15, 2025
Contributor
juliapampus
left a comment
juliapampus
left a comment
There was a problem hiding this comment.
Waiting for feedback in #154
juliapampus
requested changes
Jun 15, 2025
Contributor
juliapampus
left a comment
juliapampus
left a comment
There was a problem hiding this comment.
callbackAddress must be removed from ContractAgreementMessage in dspace.jsonld @wolf4ood
wolf4ood
force-pushed
the
fix/154_callbackaddress
branch
from
195241a to
bdd78ce
Compare
Contributor
Author
|
@jimmarino as asked I've amended this PR reflecting the #154 |
juliapampus
changed the title
juliapampus
approved these changes
Jun 26, 2025
juliapampus
changed the title
juliapampus
changed the title
juliapampus
merged commit 1ba2e0b
into
eclipse-dataspace-protocol-base:main
8 of 9 checks passed
This was referenced Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Removes
callbackAddressfromContractAgreementMessageit also changes
ContractOfferMessage. ThecallbackAddressis not mandatory anymore, but instead as suggestedin #154
one of
consumerPidorcallbackAddressare mandatory depending if it's a counterOffer or a provider initiated CNWhy it does that
Redundant property
Further notes
List other areas of the documents that have changed but are not necessarily linked to the main feature. This could be editorial changes or mistakes in example files that were encountered and were fixed inline, etc.
Linked Issue(s)
Relates #154
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.