Integration tests for policy imports enhancements#22
Open
thjaeckle wants to merge 4 commits intoeclipse-ditto:mainfrom
Open
Integration tests for policy imports enhancements#22thjaeckle wants to merge 4 commits intoeclipse-ditto:mainfrom
thjaeckle wants to merge 4 commits intoeclipse-ditto:mainfrom
Conversation
…esAdditions
- PolicyImportSubResourcesIT: tests GET/PUT /imports/{id}/entries,
GET/PUT /imports/{id}/entriesAdditions, GET/PUT/DELETE
/imports/{id}/entriesAdditions/{label} including thing access verification
- PolicyEntryImportableSubResourcesIT: tests GET/PUT
/entries/{label}/importable and /entries/{label}/allowedImportAdditions
including thing access verification
- PolicyImportEntriesAdditionsIT: tests entriesAdditions and
allowedImportAdditions policy-level validation
- ThingsWithImportedPoliciesEntriesAdditionsIT: tests thing access
granted/revoked via entriesAdditions subject additions
- PolicyImportEntriesAdditionsWsIT: WebSocket variant of access verification
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- fix templateRevokePreservedWhenResourceAdditionsOverlap: remove defaultSubject from template DEFAULT entry to avoid imported WRITE revoke blocking thing creation, and expect FORBIDDEN instead of NOT_FOUND since subject2 has READ but not WRITE - fix WS test: add policyId to CreateThing and thing:/ permissions to importing policy's ADMIN entry - add resourceAdditionGrantsWriteAccess: e2e test verifying resource additions actually grant thing WRITE access - add additionsForMultipleImportedLabels: e2e test with subject additions targeting two imported labels (DEFAULT=READ, EXTRA=WRITE) - add putPolicyImportWithMultipleResourceAdditionsAllowed: API test for multiple resources in a single EntryAddition - add putPolicyImportWithAdditionsForMultipleLabels: API test for entriesAdditions targeting multiple labels - add removingResourcesFromAllowedAdditionsRejectsNewResourceAdditions: test that narrowing allowedImportAdditions rejects resource additions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
System tests run: https://github.com/eclipse-ditto/ditto/actions/runs/22302981477 |
Add 7 tests covering cache invalidation, permission precedence, multi-importer scenarios, and sub-path granularity for entriesAdditions: - template revoke overrides resource addition grant - template entry deletion revokes entriesAdditions access - template policy deletion revokes imported access - multiple importers from same template are independently affected - subject retains access from own entry when entriesAdditions removed - resource addition respects sub-path granularity (attributes vs features) - resource addition without subject addition applies to template subjects Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Added additional integration tests to test cases where
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to Ditto PR eclipse-ditto/ditto#2221