#2277 Add prerequisite-conditions for OpenID Connect JWT validation #2323
+463
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… validation
Adds a new 'prerequisite-conditions' configuration option to OpenID Connect
issuer configuration that allows early rejection of JWTs that don't meet
certain criteria (e.g., audience validation). This enables Ditto to quickly
reject tokens with a 401 before any policy/access control checks.
Configuration example:
```
openid-connect-issuers = {
myprovider = {
issuer = "localhost:9000"
prerequisite-conditions = [
"{{ jwt:aud | fn:filter('eq','expected-audience') }}"
]
auth-subjects = ["{{ jwt:sub }}"]
}
}
```
Changes:
- Add PREREQUISITE_CONDITIONS config value to SubjectIssuerConfig
- Add prerequisiteConditions field to DefaultSubjectIssuerConfig and
JwtSubjectIssuerConfig
- Add DittoHeaders parameter to JwtAuthorizationSubjectsProvider for
correlation ID logging
- Create GatewayJwtPrerequisiteConditionNotMetException (401 error)
- Implement condition check in DittoJwtAuthorizationSubjectsProvider
- Update Helm templates for prerequisite-conditions support
- Add unit tests for prerequisite condition validation
Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
Merge pull request eclipse-ditto#20 from beyonnex-io/extend-mapper-to-include-delete-fields
add test for the includeDeletedFields option
thjaeckle
force-pushed
the
feature/openid-conditions-filter
branch
from
f31f594 to
13bb099
Compare
Member
Author
|
System tests passed: https://github.com/eclipse-ditto/ditto/actions/runs/21483900273 |
Member
Author
|
@alstanchev could you have a look at this one, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new 'prerequisite-conditions' configuration option to OpenID Connect issuer configuration that allows early rejection of JWTs that don't meet certain criteria (e.g., audience validation). This enables Ditto to quickly reject tokens with a 401 before any policy/access control checks.
Configuration example:
Resolves: #2277