Fix flaky tests MqttClientActorTest#testConnectionIsSuccessful and PubSubFactoryTest#failAckDeclarationDueToRemoteConflict#2342
Merged
thjaeckle merged 2 commits intoFeb 17, 2026
Conversation
Disconnect the MQTT client before sending the reply in ConnectionTesterActor.testConnection(). Previously, the reply triggered an inline callback chain (via CallingThreadDispatcher) that terminated the actor before disconnectMqttClient() executed, causing the test's verify(genericMqttClient).disconnect() to fail intermittently. Also remove the redundant first verify call in the test — the single verify after expectTerminated is sufficient. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test waited for heartbeats on system2 (the writer) but did not ensure the DData had actually been replicated to system1 (the reader). Replace waitForHeartBeats(system2) with a new waitForRemoteAcks helper that deterministically waits for system1 to receive a RemoteAcksChanged event containing the expected ack label before asserting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thjaeckle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disconnect the MQTT client before sending the reply in ConnectionTesterActor.testConnection(). Previously, the reply triggered an inline callback chain (via CallingThreadDispatcher) that terminated the actor before disconnectMqttClient() executed, causing the test's verify(genericMqttClient).disconnect() to fail intermittently.
Also remove the redundant first verify call in the test — the single verify after expectTerminated is sufficient.