Fix MqttClientActorTest failures by replacing static mocking with constructor injection#2345
Merged
thjaeckle merged 1 commit intoFeb 17, 2026
Conversation
…structor injection
The Mockito 5 upgrade broke the `MockedStatic<GenericMqttClientFactory>`
pattern, causing all 8 MqttClientActorTest tests to fail on CI with
`ConnectionFailedException("Connection attempt timed out")`. The static
mock no longer intercepted `GenericMqttClientFactory.newInstance()`, so
real HiveMQ clients were created instead of mocks.
Follow the established `RabbitMQClientActor` pattern: add a second
constructor accepting `GenericMqttClientFactory` and a package-private
`propsForTests()` method. This eliminates `MockedStatic` entirely,
avoiding all thread-locality and Mockito version issues.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mockito 5 upgrade broke the
MockedStatic<GenericMqttClientFactory>pattern, causing all 8 MqttClientActorTest tests to fail on CI withConnectionFailedException("Connection attempt timed out"). The static mock no longer interceptedGenericMqttClientFactory.newInstance(), so real HiveMQ clients were created instead of mocks.Follow the established
RabbitMQClientActorpattern: add a second constructor acceptingGenericMqttClientFactoryand a package-privatepropsForTests()method. This eliminatesMockedStaticentirely, avoiding all thread-locality and Mockito version issues.