Convert enforcement AskTimeoutException to 503 instead of 500#2441
Merged
thjaeckle merged 1 commit intoMay 12, 2026
Merged
Conversation
During rolling restarts, AskTimeoutException from the enforcer child was wrapped as DittoInternalErrorException (HTTP 500). This is misleading — the timeout is transient and clients should retry. Introduce EnforcementTimeoutException (HTTP 503) and convert AskTimeoutException to it in getEnforcementExceptionAsRuntimeException. Also unwrap CompletionException wrappers from async chains before checking the exception type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Aleksandar Stanchev <aleksandar.stanchev@bosch.com>
alstanchev
force-pushed
the
fix/enforcer-internal-error
branch
from
079fc41 to
a66ef60
Compare
thjaeckle
approved these changes
May 12, 2026
Member
thjaeckle
left a comment
thjaeckle
left a comment
There was a problem hiding this comment.
LGTM 👍
Thx @alstanchev
We can also add this to 3.9.0
thjaeckle
added a commit
to beyonnex-io/ditto
that referenced
this pull request
May 12, 2026
Adds PRs eclipse-ditto#2440 (JFR CPU optimisations), eclipse-ditto#2441 / eclipse-ditto#2439 (AskTimeoutException to 503), eclipse-ditto#2442 (Helm OIDC issuers), eclipse-ditto#2444 / eclipse-ditto#2443 (ssl-config fix), eclipse-ditto#2445 (MongoDB X509 auth), eclipse-ditto#2446 (stackless 4xx exceptions) and eclipse-ditto#2447 (configurable SSE backpressure) to the release notes and blogpost. Renames the announcement post to 2026-05-13. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During rolling restarts, AskTimeoutException from the enforcer child was wrapped as DittoInternalErrorException (HTTP 500). This is misleading — the timeout is transient and clients should retry.
Introduce EnforcementTimeoutException (HTTP 503) and convert AskTimeoutException to it in getEnforcementExceptionAsRuntimeException. Also unwrap CompletionException wrappers from async chains before checking the exception type.
Fixes #2439