Remove runtime requirement on org.osgi.service.component.annotations#224
Merged
scottslewis merged 1 commit intoeclipse-ecf:masterfrom Aug 20, 2025
Merged
Remove runtime requirement on org.osgi.service.component.annotations#224scottslewis merged 1 commit intoeclipse-ecf:masterfrom
scottslewis merged 1 commit intoeclipse-ecf:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Contributor
Author
|
Is there hope for this one? |
scottslewis
reviewed
Aug 18, 2025
Contributor
scottslewis
left a comment
scottslewis
left a comment
There was a problem hiding this comment.
Please include the appropriate bundle and feature version increments...both pom and manifest. The top-level features have already been incremented to 3.16.4.
These are needed only at build time for DS xml files generation and both Tycho and PDE will handle setting it up proper without needless explicit runtime dependency.
Contributor
Author
Done. |
Contributor
Author
|
I see there was new release but this one wasn't applied. Did I miss smth in the change? |
Contributor
|
My mistake. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are needed only at build time for DS xml files generation and both Tycho and PDE will handle setting it up proper without needless explicit runtime dependency.