Skip to content

Fix proxy authentication failure in Native mode#237

Merged
scottslewis merged 1 commit intoeclipse-ecf:masterfrom
nbauma109:native-proxy
Mar 20, 2026
Merged

Fix proxy authentication failure in Native mode#237
scottslewis merged 1 commit intoeclipse-ecf:masterfrom
nbauma109:native-proxy

Conversation

@nbauma109
Copy link
Copy Markdown
Contributor

Fixes #236

Please review, and let me know your concerns if this really isn’t the right place.

Signed-off-by: Nicolas Baumann <nbauma109@users.noreply.github.com>
@eclipse-ecf-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@scottslewis
Copy link
Copy Markdown
Contributor

This is indeed in the ECF filetransfer codebase, and I will apply it. I can't guarantee a timely release though. Probably the annual release in June would be target.

However, the httpclient5 provider is on it's way out of Eclipse...and the intention has always been that only the jreprovider only would eventually be used in Eclipse.

I have not been in touch with the people making/planning/doing that transition so let's include @merks

@merks
Copy link
Copy Markdown
Contributor

merks commented Mar 20, 2026

Unfortunately no person or group seems inclined to upgrade the JRE-based provider to cover all the complex proxy-types of network topologies. 😢 So mostly the new provider is being suppressed, e.g., in the Eclipse Installer and the EPP IDEs. On the brighter side, the GOAWAY problems seem to have gone away with fixes in the newer JREs.

Please keep the SimRel schedule in mind:

https://eclipse.dev/simrel/?file=wiki/SimRel/2026-06.md

You should expect that anything not released significantly before the Platform's RC2+0 on May 29 (where the builds are produced 2 days earlier for testing) will not be included in SimRel:

image

So best to aim for something before May 22nd.

@nbauma109
Copy link
Copy Markdown
Contributor Author

Not sure to understand. Which direction is Eclipse taking ?

  • are they removing http5client, in which case my little fix serves no purpose ?
  • Or, are they changing their mind because nobody is inclined to handle all proxy-related problematics ? in which case the fix is useful for next SimRel ?

@merks
Copy link
Copy Markdown
Contributor

merks commented Mar 20, 2026

There are several provider implementations.

image

The newest one is org.eclipse.ecf.provider.filetransfer.httpclientjava and both org.eclipse.ecf.provider.filetransfer.httpclientjava and org.eclipse.ecf.provider.filetransfer.httpclient5 are installed in the current Eclipse IDE packages. Those packages also use the follow to disable the newer one.

-Dorg.eclipse.ecf.provider.filetransfer.excludeContributors=org.eclipse.ecf.provider.filetransfer.httpclientjava

The reason is that the newer one does not handle all the proxy stuff, so while the newer one works fine in a normal/simple context, it does not work well in most corporate contexts where a proxy and firewalls are involved.

So this is a long winded way of saying that your fix is still very relevant and will be used in any new release of the IDEs, e.g., for 2026-06, assuming ECF produces a release in time for contribution.

@scottslewis scottslewis merged commit 5b85255 into eclipse-ecf:master Mar 20, 2026
1 check passed
scottslewis added a commit to scottslewis/ecf that referenced this pull request Mar 20, 2026
org.eclipse.provider.filetransfer.httpclient5 bundle.  Amendment to
merged pr:  eclipse-ecf#237
scottslewis added a commit that referenced this pull request Mar 21, 2026
Updated version from 1.1.102 to 1.1.200 for pr #237, updated associated feature version and updated top-level versions from 3.16.5 to upcoming 3.16.6 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marketplace installation fails behind authenticated proxy when Eclipse Network Connections is set to Native, but works in Manual

4 participants