Skip to content

Multi tenancy#38

Closed
sanath-madhav wants to merge 5 commits into
eclipse-ecsp:17-feat-abstractroutingdatasource-implementation-for-multitenancyfrom
sanath-madhav:multi-tenancy
Closed

Multi tenancy#38
sanath-madhav wants to merge 5 commits into
eclipse-ecsp:17-feat-abstractroutingdatasource-implementation-for-multitenancyfrom
sanath-madhav:multi-tenancy

Conversation

@sanath-madhav
Copy link
Copy Markdown

Please refer to our contributing docs for any questions on submitting a pull request.
Issues are required for both bug fixes and features.

Resolves #558
https://github.com/HARMAN-Auto/sp-platform-productenablers-sql-dao/issues/29

Describe behaviour before the change

  • Multi tenancy for static configuration

Describe behaviour after the change

  • Multi tenancy for dynamic configuration

Pull request checklist

  • I have read the CONTRIBUTING.md
  • My code follows the code style of this project
  • Tests for the changes have been added (for bug fixes / features)
  • All new and existing tests passed.
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

  • Yes
  • No

Comment thread src/main/java/org/eclipse/ecsp/sql/multitenancy/TenantAwareDataSource.java Outdated
Comment thread src/main/java/org/eclipse/ecsp/sql/multitenancy/TenantAwareDataSource.java Outdated
Comment thread src/main/java/org/eclipse/ecsp/sql/multitenancy/TenantAwareDataSource.java Outdated
@kaushalaroraharman
Copy link
Copy Markdown
Contributor

Note, the current implementation expects the integrating service to notify SQL-DAO via a method call to addOrUpdateTenantDataSource() method whenever the refresh event is received by the application. This is a limitation, and needs to be enhanced in the future to make sql-dao self-sufficient in listening to the refresh events and taking appropriate action. For now, approving this PR with this known limitation.

@sanath-madhav FYI.

@kaushalaroraharman
Copy link
Copy Markdown
Contributor

Merged with #40. Closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants