Bugfix/22 bug nullpointerexception with ecu type#24
Merged
kaushalaroraharman merged 2 commits intoMay 13, 2025
Conversation
…iteEvent while deciding the flow for the IgniteEvent.
…exception-with-ecu-type Issue #22 Fixed NullPointerException if ecuType is not set in the IgniteEvent while deciding the flow for the IgniteEvent.
Contributor
Author
kaushalaroraharman
left a comment
kaushalaroraharman
left a comment
There was a problem hiding this comment.
Review Feedback
Correctness:
Adding value.getEcuType() != null prevents potential NullPointerException when calling toLowerCase(). This change is logical and enhances the safety of the code.
Code Style:
The change adheres to standard Java practices for null-checking and ensures defensive programming.
Performance:
No significant performance impact is expected as the added condition is a simple null-check.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #22
Describe behaviour before the change
Describe behaviour after the change
Pull request checklist
Does this introduce a breaking change?