Skip to content

Bugfix/34 bug dma not deleting entry for retries from redis#39

Merged
kaushalaroraharman merged 2 commits into
mainfrom
bugfix/34-bug-dma-not-deleting-entry-for-retries-from-redis
May 28, 2025
Merged

Bugfix/34 bug dma not deleting entry for retries from redis#39
kaushalaroraharman merged 2 commits into
mainfrom
bugfix/34-bug-dma-not-deleting-entry-for-retries-from-redis

Conversation

@kaushalaroraharman
Copy link
Copy Markdown
Contributor

Resolves #34


Describe behaviour before the change

  • DMA was using vehicleID from the event information when creating key for retry records in Redis. If an event came in with key as something other than vehicleID, then the functionality for retries was not working as expected. Retry records were not being fetched, and deleted upon receiving ACK from the vehicle due to this, leading to unnecessary retries.

Describe behaviour after the change

  • DMA will not use the key from the event to form the key for storing retry records in Redis. The functionality of concatenating this with messageID and taskID remains unchanged and unaffected.

Pull request checklist

  • I have read the CONTRIBUTING.md
  • My code follows the code style of this project
  • Tests for the changes have been added (for bug fixes / features)
  • All new and existing tests passed.
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

  • Yes
  • No

@kaushalaroraharman kaushalaroraharman merged commit 7f82a90 into main May 28, 2025
9 of 11 checks passed
@kaushalaroraharman kaushalaroraharman self-assigned this May 28, 2025
@kaushalaroraharman kaushalaroraharman added the bug Something isn't working label May 28, 2025
@kaushalaroraharman kaushalaroraharman added this to the 1.1.2 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: DMA not deleting entry for retries from Redis upon receiving ACK from vehicle

1 participant