feat: improve DataFlow termination#3560
Merged
ndr-brt merged 1 commit intoeclipse-edc:mainfrom Oct 25, 2023
Merged
Conversation
ndr-brt
added
enhancement
ndr-brt
force-pushed
the
3422-data-flow-termination
branch
from
09fa98f to
818b04f
Compare
paullatzelsperger
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds a
TERMINATEDstate on theDataFlow, to distinguish between a completed data flow (when the data plane completed it) and a terminated one (when the data flow gets stopped by an external actor, like the policy manager).Why it does that
policy monitor
Further notes
Linked Issue(s)
PArt of #3422
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.