chore: fix scope in case of empty one from policy expression#3933
Merged
wolf4ood merged 3 commits intoeclipse-edc:mainfrom Feb 28, 2024
Merged
chore: fix scope in case of empty one from policy expression#3933wolf4ood merged 3 commits intoeclipse-edc:mainfrom
wolf4ood merged 3 commits intoeclipse-edc:mainfrom
Conversation
wolf4ood
requested review from
juliapampus,
ndr-brt and
ronjaquensel
as code owners
jimmarino
approved these changes
Feb 28, 2024
ndr-brt
approved these changes
Feb 28, 2024
…/protocol/dsp/dispatcher/DspHttpRemoteMessageDispatcherImpl.java Co-authored-by: ndr_brt <andrea.bertagnolli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Fixes the calculation of the scope. Currently if there are no polic pre/post validators the
scopesset from the evaluation process is always empty and that will be set asscopeclaim in theTokenParametersthat leads the OAuth2 Identity service to send thescopeparameter empty to the AuthService.The fix applied check If the scopes set deriving from the policy evaluation is empty, then no
scopeclaim is appliedIf there is a custom
TokenDecoratorthat adds thescopeclaim, it will override the policy evaluation one if any.Why it does that
bug fix OAuth2 Identity Service
Linked Issue(s)
Closes #3923
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.