refactor: make resource manifest generator handle TransferProcess#3979
Merged
ndr-brt merged 2 commits intoeclipse-edc:mainfrom Mar 8, 2024
Merged
Conversation
ndr-brt
added
refactoring
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
|
|
||
| boolean canGenerate(DataRequest dataRequest, DataAddress assetAddress, Policy policy); | ||
| boolean canGenerate(TransferProcess transferProcess, DataAddress assetAddress, Policy policy); |
Check notice
Code scanning / CodeQL
Useless parameter
| */ | ||
|
|
||
| boolean canGenerate(DataRequest dataRequest, DataAddress assetAddress, Policy policy); | ||
| boolean canGenerate(TransferProcess transferProcess, DataAddress assetAddress, Policy policy); |
Check notice
Code scanning / CodeQL
Useless parameter
| */ | ||
| @Nullable | ||
| ResourceDefinition generate(DataRequest dataRequest, DataAddress assetAddress, Policy policy); | ||
| ResourceDefinition generate(TransferProcess transferProcess, DataAddress assetAddress, Policy policy); |
Check notice
Code scanning / CodeQL
Useless parameter
| */ | ||
| @Nullable | ||
| ResourceDefinition generate(DataRequest dataRequest, DataAddress assetAddress, Policy policy); | ||
| ResourceDefinition generate(TransferProcess transferProcess, DataAddress assetAddress, Policy policy); |
Check notice
Code scanning / CodeQL
Useless parameter
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3979 +/- ##
==========================================
+ Coverage 71.74% 73.39% +1.64%
==========================================
Files 919 961 +42
Lines 18457 19392 +935
Branches 1037 1093 +56
==========================================
+ Hits 13242 14232 +990
+ Misses 4756 4696 -60
- Partials 459 464 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ndr-brt
changed the title
ndr-brt
force-pushed
the
3732-purge-data-request-part-one
branch
from
46d485b to
621aaff
Compare
…tead of DataRequest
ndr-brt
force-pushed
the
3732-purge-data-request-part-one
branch
from
621aaff to
1e561b2
Compare
paullatzelsperger
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
First refactoring step to inline
DataRequest, makeResourceManifestGeneratorand relative consumer/provider interfaces to acceptTransferProcessinstead ofDataRequest** Breaking change ** for those who implemented a custom
ConsumerResourceDefinitionGeneratoror aProviderResourceDefinitionGenerator, pretty straightforward to adaptWhy it does that
refactoring
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Part of #3732
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.