feat: move transfer initiate into command handler#5579
Merged
ndr-brt merged 1 commit intoeclipse-edc:mainfrom Mar 20, 2026
Merged
feat: move transfer initiate into command handler#5579ndr-brt merged 1 commit intoeclipse-edc:mainfrom
ndr-brt merged 1 commit intoeclipse-edc:mainfrom
Conversation
ndr-brt
force-pushed
the
5573-move-initiate-out-manager
branch
from
f0c3653 to
d7c9867
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .dataplaneMetadata(transferRequest.getDataplaneMetadata()) | ||
| .build(); | ||
|
|
||
| var dataAddressStorage = Optional.ofNullable(transferRequest.getDataDestination()) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
wolf4ood
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Moved
TransferProcessinitiate method into command handler.Why it does that
move logic out of managers
Further notes
TransferRequestmessage allowed custom id to be used, I guess for a point in time in which this was useful, but, to align with theContractRequestthat doesn't permit that, I just removed its evaluation, and the id is automatically generated by the system. This permitted to avoid looking for duplicates, plus, there's no real reason to maintain externally generated ids.CommandResultcontent as it was introduced in refactor: move negotiation initialize logic into command handler #5576 to get the job done, but actually the information that's needed by the service layer (entity id and createdAt) are already available there, and the command should stay without content, for sake of simplicityWho will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #5573
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.