Skip to content

feat: @Configuration Map#5649

Merged
ndr-brt merged 1 commit intomainfrom
5648-configuration-map
Apr 13, 2026
Merged

feat: @Configuration Map#5649
ndr-brt merged 1 commit intomainfrom
5648-configuration-map

Conversation

@ndr-brt
Copy link
Copy Markdown
Member

@ndr-brt ndr-brt commented Apr 10, 2026

What this PR changes/adds

Permits to inject configurations Map, e.g.

    @SettingContext("web.http")
    @Configuration
    private Map<String, AuthenticationConfiguration> authenticationConfigurationMap;

instead to have to do it manually as for now.
This solution is shown in ApiAuthenticationConfigurationExtension, LocalPublicKeyDefaultExtension and TrustedIssuerConfigurationExtension

Why it does that

usability

Further notes

  • I refactored the setting and config tests A LOT, because they were quite complicated and not well scoped.
  • Apparently the InjectionPoint does too much, that's why tests were (and still are IMHO) too complicated. My first thought is that we could/should separate the "resolution" part and introduce a InjectionPointResolver interface, so the resolution logic can be moved there and leave to the InjectionPoint only the "providers" knowledge.

Who will sponsor this feature?

Please @-mention the committer that will sponsor your feature.

Linked Issue(s)

Closes #5648

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the enhancement New feature or request label Apr 10, 2026
@ndr-brt ndr-brt force-pushed the 5648-configuration-map branch from c8ecf63 to f243057 Compare April 10, 2026 11:49
@ndr-brt ndr-brt changed the title 5648 configuration map feat: @Configuration Map Apr 10, 2026
@ndr-brt ndr-brt force-pushed the 5648-configuration-map branch from f243057 to ac376ca Compare April 13, 2026 07:31
@ndr-brt ndr-brt marked this pull request as ready for review April 13, 2026 07:31
@ndr-brt ndr-brt requested a review from a team as a code owner April 13, 2026 07:31
@ndr-brt ndr-brt force-pushed the 5648-configuration-map branch 3 times, most recently from d0d869d to b4ce960 Compare April 13, 2026 11:41
@ndr-brt ndr-brt force-pushed the 5648-configuration-map branch from b4ce960 to 10f3778 Compare April 13, 2026 11:58
@ndr-brt ndr-brt merged commit 09618d5 into main Apr 13, 2026
20 checks passed
@ndr-brt ndr-brt deleted the 5648-configuration-map branch April 13, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration map

2 participants