fix: make VP holder property optional#5697
Merged
paullatzelsperger merged 2 commits intoeclipse-edc:mainfrom Apr 23, 2026
Merged
fix: make VP holder property optional#5697paullatzelsperger merged 2 commits intoeclipse-edc:mainfrom
paullatzelsperger merged 2 commits intoeclipse-edc:mainfrom
Conversation
- JwtToVerifiablePresentationTransformer now reads an explicit `holder` claim from the VP JWT and falls back to the `iss` (issuer) claim when absent, instead of always using the issuer - VerifiableCredentialValidationServiceImpl skips HasValidSubjectIds validation when the presentation holder is null, allowing VPs that carry no holder to pass validation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
paullatzelsperger
force-pushed
the
fix/presentation_holder_is_optional
branch
from
97a008e to
4fcdade
Compare
jimmarino
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR achieves two things:
holderproperty is taken from theholderclaim, not theissclaimholderproperty is present on a presentation, theHasValidSubjectIdsrule is not appliedWhy it does that
the
holderproperty is optional in both VCDM1.1 and VCDM2.0 and DCP does not require it either.Further notes
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #5695
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.