fix: remove address validation from AssetService, fix metadata deserialization#5720
Merged
fix: remove address validation from AssetService, fix metadata deserialization#5720
Conversation
ndr-brt
force-pushed
the
5708-remove-dataaddress-validation
branch
from
f711197 to
928789d
Compare
ndr-brt
changed the title
ndr-brt
force-pushed
the
5708-remove-dataaddress-validation
branch
from
928789d to
dc235ca
Compare
ndr-brt
changed the title
ndr-brt
force-pushed
the
5708-remove-dataaddress-validation
branch
2 times, most recently
from
6a168ea to
3302bc1
Compare
ronjaquensel
approved these changes
May 5, 2026
wolf4ood
reviewed
May 5, 2026
ndr-brt
force-pushed
the
5708-remove-dataaddress-validation
branch
2 times, most recently
from
4b1bbeb to
8278487
Compare
…Metadata deserialization
ndr-brt
force-pushed
the
5708-remove-dataaddress-validation
branch
from
8278487 to
8d3f115
Compare
wolf4ood
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Remove
DataAddressvalidation fromAssetService, as asset should not be mandatory anymore.Fixed also DataplaneMetadata deserialization
Why it does that
fix bug
Further notes
Asset.dataAddressis still used for theCatalogcreation, especially when theAssetis meant to point to anotherCatalog. that needs to be solved differently (a separate issue will be opened)Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #5708
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.