fix: return only permitted credentials instead of rejecting out-of-scope requests#992
Merged
paullatzelsperger merged 4 commits intoMay 21, 2026
Conversation
…ope requests When a client requests credentials outside their permitted scope, filter them out and return only the allowed ones, logging a warning instead of failing the entire request. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ndr-brt
approved these changes
May 21, 2026
Introduces CredentialProfile utility to translate between DCP profile strings (e.g. vc11-sl2021/jwt, vc20-bssl/jwt) and CredentialFormat enum values, replacing the previous raw enum-name parsing in CredentialWriterImpl and DcpCredentialStorageClient. Also updates TCK runtime image and library coordinates to 1.0.0-RC7. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
When a client requests credentials outside their permitted scope, filter them
out and return only the allowed ones, logging a warning instead of failing the
entire request.
Why it does that
dcp spec mandates that
Further notes
TCK tests will fail until this is also updated in the TCKs!
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #990
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.