Improvements in logging#285
Conversation
196add5 to
fa2994d
Compare
|
@pzygielo Could you please review this? I would then continue with some automated cleanup steps in another PRs:
Then ...
GF8+ will also do more iterations in the direction of eclipse-ee4j/glassfish#25804 to simplify the initialization of ORB. At this moment I don't know if it will need more changes in this project, but it is possible. Finally this project is not in so bad shape as I originally thought, but ORB initialization is quite complex and was made even more complex and obfuscated in GlassFish. The cause is that components spark initialization of other components and they depend on each other, on properties set for each other, so the sequence must be perfectly controlled. Some runtime components are in this library, some are in GlassFish, and the hell is open. |
pzygielo
left a comment
There was a problem hiding this comment.
I've not looked at ORBImpl yet.
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…nnotations Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- added toStringMethods - added loggers - ignored exceptions moved to addSuppressed Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
a9e885d to
362396c
Compare
InterruptedExceptionThe initialization is heavily dependent on the order of operations, part is done from GlassFish, another is sparked from
setParametersmethod call and finished by PEORBConfigurator. I would like to make it more robust in the future, but I need to know perfectly the required order of operations.The #288 should be merged first!