Conversation
Logging: We want to to log errors and failures by default to prevent those problems from being swallowed up since they may contain important information about underlying issues. EPackageConfigurations: Centralize EPackageConfiguration management and apply it on the Java model server client to ensure proper setup. We also ensure that the ChangePackage is properly initialized on the client-side. We already use the RecordingModelResourceManager as default on the server so we need the ChangePackage to be initialized.
ndoschek
approved these changes
Jun 8, 2021
Member
ndoschek
left a comment
ndoschek
left a comment
There was a problem hiding this comment.
Thanks a lot for your change Martin! LGTM 👍
(PS: CI seems to have network issues again. I executed the builds locally and they went through fine in my case, so I will merge it)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging:
We want to to log errors and failures by default to prevent those
problems from being swallowed up since they may contain important
information about underlying issues.
EPackageConfigurations:
Centralize EPackageConfiguration management and apply it on the Java
model server client to ensure proper setup. We also ensure that the
ChangePackage is properly initialized on the client-side. We already use
the RecordingModelResourceManager as default on the server so we need
the ChangePackage to be initialized.