#187 Fix logging configuration for JAR product#229
Merged
Conversation
- Update log configuration - If file path is given, reconfigure logging based on this configuration - Default case configures console logging to level INFO, no file logging - Add ExampleServerLauncher.launch configuration that uses the example log configuration (console and file logging at level info) - Remove log configuration files from classpath to avoid unwanted configuration aggregation - Fix performance warning that causes log42j logging issue if executed in bundled jar - Switch to import instead of require plugin bundles for log4j dependencies - Update lib dependencies - Do not exclude source libs to improve debugging experiences in p2 use case - Update README - Update logging section - Format via markdownlint and remove markdownlint warnings - Update import project section and remove outdated information - targetplatform project - Include targetplatform as module of releng parent project to be able to import all projects as maven projects without exception - Remove unused targetplatform profile Part of #187
This was referenced Jul 5, 2022
cdamus
requested changes
Jul 7, 2022
Contributor
cdamus
left a comment
cdamus
left a comment
There was a problem hiding this comment.
Wow, that is a thorough clean-up for developer usability. Thanks!
I do have a few quibbles in comments in-line. Also, there's a problem in the formatting in the new README:
This section lost the fence around the code block and all of the indentation within it.
- Update log4j version range - Update README - example: Switch log4j-slf4j-impl dependency for modelserver.lib to avoid warning on startup
Member
Author
|
Thanks a lot for you review @cdamus, I addressed your comments with a separate commit, would be great if you could have another quick look, thanks again! |
- Previous mirror seems to be out of maintenance since 2017
cdamus
approved these changes
Jul 8, 2022
| public static void configureLogger(final Optional<String> configurationFilePath) { | ||
| if (configurationFilePath.isPresent()) { | ||
| protected static void configureLogger(final String configurationFilePath) { | ||
| if (configurationFilePath != null && !configurationFilePath.isEmpty()) { |
Contributor
There was a problem hiding this comment.
Good catch on the present-but-empty string! 😀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #187
Please also have a look at eclipse-emfcloud/emfcloud-modelserver-theia#110