Skip to content

[532244] adequate HTML label doubleClicking support#16

Merged
miklossy merged 1 commit intoeclipse-gef:masterfrom
wntrzo:532244_Doubleclicking_HTML_Like_Labels_extendedSelection
May 17, 2018
Merged

[532244] adequate HTML label doubleClicking support#16
miklossy merged 1 commit intoeclipse-gef:masterfrom
wntrzo:532244_Doubleclicking_HTML_Like_Labels_extendedSelection

Conversation

@wntrzo
Copy link
Copy Markdown
Contributor

@wntrzo wntrzo commented May 17, 2018

  • new DotHtmlLabelDoubleClickStrategy implemented
  • adapted DotTerminalsTokenTypeToPartitionMapper to introduce custom
    HTML label partitionType
  • custom DotDoubleClickStrategyProvider to provide
    DotHtmlLabelDoubleClickStrategy for custom HTML label partitionType
  • adapted DotHtmlLabelTerminalsTokenTypeToPartitionMapper to introduce
    custom HTML text type
  • custom DotHtmlLabelDoubleClickStrategyProvider to map text type
  • bound custom DotDoubleClickStrategyProvider in DotUiModule
  • bound custom DotHtmlLabelDoubleClickStrategyProvider in
    DotHtmlLabelUiModule
  • DotEditorDoubleClickingTests extended for HTML label cases
  • DotHtmlLabelTokenTypeToPartitionMapperTests and
    DotTokenTypeToPartitionMapperTests changed to expect amended results

Signed-off-by: Zoey Gerrit Prigge zoey.prigge@uni-duesseldorf.de
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=532244

- new DotHtmlLabelDoubleClickStrategy implemented
- adapted DotTerminalsTokenTypeToPartitionMapper to introduce custom
HTML label partitionType
- custom DotDoubleClickStrategyProvider to provide
DotHtmlLabelDoubleClickStrategy for custom HTML label partitionType
- adapted DotHtmlLabelTerminalsTokenTypeToPartitionMapper to introduce
custom HTML text type
- custom DotHtmlLabelDoubleClickStrategyProvider to map text type
- bound custom DotDoubleClickStrategyProvider in DotUiModule
- bound custom DotHtmlLabelDoubleClickStrategyProvider in
DotHtmlLabelUiModule
- DotEditorDoubleClickingTests extended for HTML label cases
- DotHtmlLabelTokenTypeToPartitionMapperTests and
DotTokenTypeToPartitionMapperTests changed to expect amended results

Signed-off-by: Zoey Gerrit Prigge <zoey.prigge@uni-duesseldorf.de>
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=532244
@eclipsewebmaster
Copy link
Copy Markdown

Issue tracker reference:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=532244

@miklossy miklossy merged commit 5ac1bf0 into eclipse-gef:master May 17, 2018
@wntrzo wntrzo deleted the 532244_Doubleclicking_HTML_Like_Labels_extendedSelection branch May 24, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants