[546593]: Immediately refresh the marquee feedback on creation#64
Merged
mwienand merged 1 commit intoeclipse-gef:masterfrom May 17, 2019
Merged
Conversation
Contributor
CamilleLetavernier
commented
Apr 19, 2019
CamilleLetavernier
commented
- After creating the MarqueeSelectionFeedback, immediately refresh it to make sure it is located under the mouse, so scrollbars won't have to be displayed if they're not necessary
- After creating the MarqueeSelectionFeedback, immediately refresh it to make sure it is located under the mouse, so scrollbars won't have to be displayed if they're not necessary Signed-off-by: Camille Letavernier <cletavernier@eclipsesource.com> Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=546593
Contributor
|
Thank you very much for the contribution! I will add an XXX comment to the new line, explaining that it prevents the scrollbars. Maybe the issue is also present with other feedback and handles, so we might have to find another place for an initial refresh, in order to resolve all such issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.